[Core] Fix proctitle for generator tasks #36928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
jjyao
changed the title
rkooo567
approved these changes
Jun 28, 2023
|
lgtm |
8 tasks
arvind-chandra
pushed a commit
to lmco/ray
that referenced
this pull request
Aug 31, 2023
For static and dynamic generator tasks, the actual task execution is inside store_task_outputs when we iterator over the generator but _changeproctitle context manager doesn't cover that part and that's why the proctitle shows as IDLE. The fix is to increase the scope of _changeproctitle so that now it covers the entire task execution including deserializing args, execution, storing outputs. Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com> Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
For static and dynamic generator tasks, the actual task execution is inside
store_task_outputswhen we iterator over the generator but_changeproctitlecontext manager doesn't cover that part and that's why the proctitle shows as IDLE. The fix is to increase the scope of_changeproctitleso that now it covers the entire task execution including deserializing args, execution, storing outputs.Related issue number
Closes #31456
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.